Promisify web3 sync requests in tests #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@LogvinovLeon Done. Let me know if I missed something. Thanks! P.S. I can squash the commits before the PR is good to merge. |
|
I'm not the maintainer, but first, make sure tests pass. |
arku
force-pushed
the
fix/web3-async-#999
branch
from
df89197 to
74c3ab9
Compare
arku
changed the title
arku
force-pushed
the
fix/web3-async-#999
branch
from
74c3ab9 to
cd2584c
Compare
|
Could you please rebase your changes of the latest |
|
@shrugs Any chance you or any other maintainer can review that? |
|
@LogvinovLeon Sure, let me do it 🙂 |
arku
force-pushed
the
fix/web3-async-#999
branch
from
cd2584c to
4aab9b9
Compare
shrugs
force-pushed
the
fix/web3-async-#999
branch
from
69e43b2 to
d59ab6f
Compare
shrugs
approved these changes
Jul 10, 2018
|
hmm, SOLC_NIGHTLY is failing because of an ECRecovery call throwing instead of returning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #999
🚀 Description
Makes use of the
toPromisehelper already present in the codebase to promisifyweb3.eth.getBalancefunction calls throughout the tests.npm run lint:all:fix).