Skip to content

Conversation

Zegeri
Copy link
Contributor

@Zegeri Zegeri commented Nov 7, 2018

This warning will almost surely show in the log file. This intends to make this warning more readable.

Before:

! Can't convert dik_name for dik[47]
! Can't convert dik_name for dik[52]
! Can't convert dik_name for dik[102]
! Can't convert dik_name for dik[104]
! Can't convert dik_name for dik[105]
! Can't convert dik_name for dik[106]
! Can't convert dik_name for dik[107]
! Can't convert dik_name for dik[108]
! Can't convert dik_name for dik[109]
! Can't convert dik_name for dik[110]
! Can't convert dik_name for dik[123]
! Can't convert dik_name for dik[124]

After:

! Can't find a key for kLBRACKET
! Can't find a key for kAPOSTROPHE
! Can't find a key for kPOWER
! Can't find a key for kF13
! Can't find a key for kF14
! Can't find a key for kF15
! Can't find a key for kF16
! Can't find a key for kF17
! Can't find a key for kF18
! Can't find a key for kF19
! Can't find a key for kCUT
! Can't find a key for kCOPY

@Xottab-DUTY
Copy link
Member

It's better to say
! Can't find a key name for %s
Otherwise user will misunderstood the log ;)

Msg("! Can't find key %s", kb.key_name);
if (kb.key_local_name.empty())
kb.key_local_name = kb.key_name;
}

// Msg("[%s]-[%s]", kb.key_name, kb.key_local_name.c_str());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove such commented lines?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are useful for debug too ;)

@Xottab-DUTY Xottab-DUTY merged commit 9396cc2 into OpenXRay:xd_dev Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants