Skip to content

Fix xrWeatherEditor compilation and one bug #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2017
Merged

Fix xrWeatherEditor compilation and one bug #179

merged 2 commits into from
Mar 17, 2017

Conversation

Xottab-DUTY
Copy link
Member

No description provided.

@Xottab-DUTY
Fix incorrect virtual method overriding.
2af4148 
Do not confuse with 52462dc
@Xottab-DUTY
Fix compilation of xrWeatherEditor
87fd7aa 
Was broken with c96c2e4
Corresponding formatting fixes
@Xottab-DUTY Xottab-DUTY mentioned this pull request Mar 15, 2017
Closed
@CrossVR
Copy link
Contributor

CrossVR commented Mar 15, 2017

Ah yes, I remember this, I thought I fixed it before committing, but apparently I forgot.

Thanks for fixing it.

@CrossVR CrossVR added Bug The issue in the run-time. Code Quality ready to merge labels Mar 15, 2017
@CrossVR CrossVR merged commit 3b50a64 into OpenXRay:dev Mar 17, 2017
@Xottab-DUTY Xottab-DUTY deleted the xrWeatherEditor branch March 28, 2017 16:07
@Xottab-DUTY Xottab-DUTY added Build issue The issue in the build-time. and removed Bug The issue in the run-time. labels Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@CrossVR CrossVR CrossVR approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Build issue The issue in the build-time. Code Quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xottab-DUTY @CrossVR