Skip to content

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Mar 26, 2025

Summary by CodeRabbit

  • Chores
    • Updated build and test workflows to use newer Python versions and align branch references.
    • Streamlined continuous integration by removing an obsolete translation workflow and revising job dependencies.
  • New Features
    • Enhanced localization with additional vocabulary entries and updated terminology for improved language support.
    • Refined the translation synchronization process to ensure cleaner, deduplicated output for multilingual content.

Copy link
Contributor

coderabbitai bot commented Mar 26, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update adjusts several GitHub Actions workflows to use Python 3.11 instead of earlier versions and revises testing matrices and branch references. A new translations job has been introduced into the release workflow with a dependency update for the publishing step. Additionally, an obsolete workflow file was removed. Vocabulary files across different locales have been updated by adding new entries, modifying existing ones, or removing redundant files. The translation synchronization script now features enhanced template expansion, deduplication, and improved file path handling.

Changes

File(s) Change Summary
.github/workflows/build_tests.yml, .github/workflows/license_tests.yml Updated python-version from 3.8 to 3.11.
.github/workflows/install_tests.yml Modified testing matrix: changed from [3.7, 3.8, 3.9, "3.10"] to ["3.10", "3.11"].
.github/workflows/publish_stable.yml Changed checkout branch from dev to master and updated python-version to 3.11.
.github/workflows/release_workflow.yml Added a new translations job (using Python 3.11) and updated dependency: publish_alpha now depends on translations; also updated python-version in related jobs.
.github/workflows/sync_tx.yml File removed.
ovos_commonqa/locale/gl-es/Play.voc Added new entries: buscar and comezar.
ovos_commonqa/locale/gl-es/QuestionWord.voc New file introducing Galician question words.
ovos_commonqa/locale/nl-nl/QuestionWord.voc Updated term: replaced Wiens with van wie.
translations/gl-es/strings File removed.
translations/gl-es/vocabs.json Added entries for "QuestionWord.voc" and revised "Play.voc" with regex-style alternatives.
scripts/sync_translations.py Enhanced translation sample processing: now applies template expansion, deduplication, and improved file path handling with directory creation.

Sequence Diagram(s)

sequenceDiagram
    participant RW as Release Workflow
    participant T as Translations Job
    participant PA as Publish Alpha Job
    participant Repo as Repository

    RW->>T: Checkout repository (dev branch)
    T->>T: Setup Python 3.11 & install ovos-utils
    T->>Repo: Run sync translations script
    T->>Repo: Commit translation updates
    T-->>RW: Job completes
    RW->>PA: Trigger publish_alpha (dependency on translations)
Loading
sequenceDiagram
    participant S as sync_translations.py
    participant Input as Translation Samples
    participant FS as File System

    S->>Input: Read samples
    S->>S: Expand templates and deduplicate samples
    S->>FS: Ensure target directory exists (os.makedirs)
    S->>FS: Write processed translations to file
Loading

Poem

Oh, I’m a rabbit with a coding hop,
Leaping in workflows that never stop.
Python upgraded—no more old tricks,
New jobs and scripts providing fresh kicks.
My whiskers twitch with a joyful cheer,
Celebrating changes with a bunny cheer!
🥕🐇 Happy hopping in every line!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7debc30 and 86455a8.

📒 Files selected for processing (12)
  • .github/workflows/build_tests.yml (1 hunks)
  • .github/workflows/install_tests.yml (1 hunks)
  • .github/workflows/license_tests.yml (1 hunks)
  • .github/workflows/publish_stable.yml (1 hunks)
  • .github/workflows/release_workflow.yml (2 hunks)
  • .github/workflows/sync_tx.yml (0 hunks)
  • ovos_commonqa/locale/gl-es/Play.voc (1 hunks)
  • ovos_commonqa/locale/gl-es/QuestionWord.voc (1 hunks)
  • ovos_commonqa/locale/nl-nl/QuestionWord.voc (1 hunks)
  • scripts/sync_translations.py (5 hunks)
  • translations/gl-es/strings (0 hunks)
  • translations/gl-es/vocabs.json (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JarbasAl JarbasAl merged commit 2ac562b into dev Mar 26, 2025
3 of 5 checks passed
JarbasAl added a commit that referenced this pull request Mar 26, 2025
* Merge pull request #36 from daniferlop/dev

Galician translation

* Intents (#37)

* fix: improve matching based on gathered open data

some utterances are not sent to common query when they should, expand the voc for the short-circuit check so more utterances are caught

* fix: improve matching based on gathered open data

some utterances are not sent to common query when they should, expand the voc for the short-circuit check so more utterances are caught

* fix: improve matching based on gathered open data

some utterances are not sent to common query when they should, expand the voc for the short-circuit check so more utterances are caught

* Increment Version to 1.1.1a1

* Update Changelog

* Fix/galician (#39)

* fix: galician

* fix: galician

* Increment Version to 1.1.1a2

* Update Changelog

---------

Co-authored-by: daniferlop <[email protected]>
Co-authored-by: JarbasAI <[email protected]>
Co-authored-by: JarbasAl <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant