fix:standardize_lang

[JarbasAl]

makes intents match regardless of upper or lowercase being used in lang code, and brings initial support for dynamic dialects

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Improved language handling in the AdaptPipeline, ensuring consistent formatting for language tags during intent matching.
  • Introduced a method for determining the closest matching language from available engines.

• Deprecations

  • Deprecated several context management properties and methods, with guidance for users to transition to configuration-based alternatives.

• Bug Fixes

  • Enhanced method signature for register_vocabulary for better type clarity.

• Chores

  • Updated test requirements by removing the cov-core dependency while retaining pytest-cov.
  • Added new dependencies: ovos-utils and langcodes.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request focus on the AdaptPipeline class within the ovos_adapt/opm.py file, enhancing the initialization process and language tag management. The constructor now uses the standardize_lang_tag function for language handling, and the match_intent method has been updated for consistent language tag formatting. Several context management properties have been deprecated, with users directed to new configuration options. Additionally, the requirements.txt file has been updated to include new dependencies and remove the cov-core dependency from test/requirements.txt.

Changes

File	Change Summary
ovos_adapt/opm.py	- Updated __init__ to use standardize_lang_tag for lang and secondary languages.
	- Modified match_intent to standardize language tag before matching.
	- Enhanced register_vocabulary method signature for type clarity.
	- Added _get_closest_lang method for finding closest language match.
	- Deprecated context management properties: context_keywords, context_max_frames, context_timeout, context_greedy, with warnings for alternatives.
	- Deprecated update_context method, advising use of Session.context.update_context.
	- Removed deprecated register_vocab method.
requirements.txt	- Added dependencies: ovos-utils>=0.3.4,<1.0.0 and langcodes.
test/requirements.txt	- Removed cov-core>=1.15.0 dependency.
	- Retained pytest-cov>=2.8.1 dependency.

Possibly related PRs

• fix:standardize_lang #10: The changes in this PR directly relate to the modifications made to the AdaptPipeline class in ovos_adapt/opm.py, specifically regarding the use of the standardize_lang_tag function for language handling and updates to the match_intent and register_vocabulary methods.

Suggested labels

enhancement

Poem

🐇 In the land of code where rabbits play,
Language tags now find their way.
With updates bright and context clear,
Intent parsing brings us cheer!
So hop along, let’s code and sing,
For every change, a joyful spring! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9a3efee and fedbd9f.

📒 Files selected for processing (2)

• ovos_adapt/opm.py (5 hunks)
• test/requirements.txt (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• test/requirements.txt

🧰 Additional context used

🪛 Ruff

ovos_adapt/opm.py

57-57: Ambiguous variable name: l

(E741)