Adopt traffic participant role specification #892
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomassedlmayer
force-pushed
the
adopt-role-harmonization
branch
3 times, most recently
from
d20c45a to
fbb8506
Compare
Signed-off-by: Thomas Sedlmayer <[email protected]>
Signed-off-by: Thomas Sedlmayer <[email protected]>
thomassedlmayer
force-pushed
the
adopt-role-harmonization
branch
from
fbb8506 to
c90791b
Compare
jakobkaths
requested changes
Dec 16, 2025
| // Traffic participant that can be perceived as freight transport, | ||
| // e.g. freight truck, delivery van, delivery bike, postman. | ||
| // | ||
| ROLE_FREIGHT_TRANSPORT = 11; |
Contributor
There was a problem hiding this comment.
I thought about this one and researched a little bit, e.g. at UPS (see screenshot). Maybe, we should use the term "shipping" instead as an umbrella term for delivery, freight, cargo etc. that would include them all, I believe.
Suggested change
| ROLE_FREIGHT_TRANSPORT = 11; | |
| ROLE_SHIPPING = 11; |
| // | ||
| ROLE_MILITARY = 10; | ||
|
|
||
| // Traffic participant that can be perceived as freight transport, |
Contributor
There was a problem hiding this comment.
See comment below.
Suggested change
| // Traffic participant that can be perceived as freight transport, | |
| // Traffic participant that can be perceived as a shipping actor, |
Contributor
There was a problem hiding this comment.
I'm not too familiar with the OSI structure, but in 3.7 I found the roles under "Vehicle Classification", see screenshot below. Is this something we need to change as we address all kinds of moving objects here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft to adopt the traffic participant role specification from https://publications.pages.asam.net/standards/ASAM_TrafficParticipants_Specification/ASAM_TrafficParticipants_Specification/v1.0.0/specification/07_traffic_participants/07_01_general.html