Skip to content

Conversation

@emjay0921
Copy link
Contributor

@emjay0921 emjay0921 commented Dec 2, 2024

Why is this change needed?

To fix the validation when deleting a gender.

How was the change implemented?

Modified the gender field type to many2one and enable the restriction of ondelete.

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • On new instance or clean instance: Install spp_farmer_registry_demo or spp_mis_demo.
  • Generate sample datas.
  • Try delete a Gender Types.
  • Error should be raised.

Related links

#641

@emjay0921 emjay0921 marked this pull request as ready for review December 2, 2024 04:42
@emjay0921 emjay0921 requested review from gonzalesedwin1123 and removed request for gonzalesedwin1123 and jeremi December 2, 2024 04:42
@gonzalesedwin1123
Copy link
Member

@emjay0921 please check the issue with the test. The compatibility issue is causing the error.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.91%. Comparing base (ca5926e) to head (4486eed).
Report is 49 commits behind head on 17.0.

Files with missing lines Patch % Lines
...armer_registry_demo/models/generate_farmer_data.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #680      +/-   ##
==========================================
+ Coverage   72.73%   72.91%   +0.17%     
==========================================
  Files         667      659       -8     
  Lines       17259    16933     -326     
  Branches     2195     2164      -31     
==========================================
- Hits        12553    12346     -207     
+ Misses       4305     4185     -120     
- Partials      401      402       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kneckinator
Copy link
Contributor

Rebasing on latest 17.0 before merge to ensure tests are passing.

@kneckinator kneckinator force-pushed the 641-fix-gender-deletion branch from 4486eed to 6352bbc Compare January 9, 2025 02:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

@kneckinator kneckinator merged commit e166e80 into 17.0 Jan 9, 2025
4 of 5 checks passed
@kneckinator kneckinator deleted the 641-fix-gender-deletion branch January 9, 2025 03:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to view group in registry when deleting gender in configurations

5 participants