-
Notifications
You must be signed in to change notification settings - Fork 24
[FIX] spp_api: Override the handle_error function #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 17.0 #672 +/- ##
==========================================
+ Coverage 75.96% 75.98% +0.02%
==========================================
Files 706 705 -1
Lines 17927 18059 +132
Branches 2223 2218 -5
==========================================
+ Hits 13618 13723 +105
- Misses 3851 3872 +21
- Partials 458 464 +6 ☔ View full report in Codecov by Sentry. |
gonzalesedwin1123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the codecov errors
9aac3bb to
14e7523
Compare
|



Why is this change needed?
To fix the
spp_apiinitialization error.How was the change implemented?
Added and overridden the function
handle_errorsince not overriding this is the cause of the api not initializing properly.New unit tests
Unit tests executed by the author
How to test manually
In Odoo:
spp_api.spp_api_records.spp_apiis in the list.bearer token.)In Postman: (Download this postman collection:
OpenSPP-ACF API.postman_collection.json)
user_prog_tokenanduser_reg_tokenreplace the value after 'Bearer' with thebearer tokenyou copied before. (Make sure the wordBearer and a blank spaceis still there before thebearer tokenyou pasted.).e.g Bearer ey........
api_urlchange the url but make sure the/api/spp_api/1/is still in the correct place.Get the list of programsor anything from the list then clickSend.Notes
I'm not sure how or if we can test this with runboat as a
private_key.pemandpublic_key.pubis needed to be stored inside the container's/etc/secrets/folder.Related links
#603