Skip to content

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Jul 29, 2025

fixes #12462 & closes #12639

Removal of buildMode: true: Since recent versions of vite-plugin-checker (v1+), this option has been:

  • removed
  • or made implicit via project configuration (tsconfig.build.json, composite: true, etc.)
    The plugin now relies on the actual TypeScript context, rather than a manual Boolean option.

Removal of api: ‘modern’: This field was never part of the official Vite or Sass API. It most likely originated from the time when Vite used an internal or experimental interface to control the Sass compiler.

  • api: ‘modern’ was not documented or officially supported.
  • He did nothing in Vite 6+, except perhaps silently ignore the option.
  • In Vite 7, with stricter typing, it is considered an error since scss must be a SassPreprocessorOptions (and this field does not exist in this interface).

@Akctarus Akctarus self-assigned this Jul 29, 2025
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jul 29, 2025
@Akctarus Akctarus removed this from Board PI 16 Jul 29, 2025
@Akctarus Akctarus marked this pull request as ready for review July 29, 2025 10:40
@Akctarus Akctarus requested a review from a team as a code owner July 29, 2025 10:40
@SharglutDev SharglutDev changed the title Tmn/front/fix bump vite 7.0.4 front: bump vite from 6.3.5 to 7.0.4 in /front Jul 29, 2025
@Akctarus Akctarus force-pushed the tmn/front/fix-bump-vite-7.0.4 branch 2 times, most recently from 090ebaa to 84cf4d2 Compare July 30, 2025 08:17
@Akctarus Akctarus requested review from SharglutDev and theocrsb July 30, 2025 08:38
@Akctarus Akctarus requested review from emersion and sim51 and removed request for SharglutDev July 30, 2025 10:01
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! Can the commits be squashed together to avoid having an in-between state with the build failing?

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.3.5 to 7.0.4.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v7.0.4/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 7.0.4
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@Akctarus Akctarus force-pushed the tmn/front/fix-bump-vite-7.0.4 branch from 84cf4d2 to 231b7ec Compare July 30, 2025 13:27
@Akctarus
Copy link
Contributor Author

Nice, LGTM! Can the commits be squashed together to avoid having an in-between state with the build failing?

Of course ! Done !

@Akctarus Akctarus added this pull request to the merge queue Jul 30, 2025
Merged via the queue into dev with commit f2be9ce Jul 30, 2025
52 of 53 checks passed
@Akctarus Akctarus deleted the tmn/front/fix-bump-vite-7.0.4 branch July 30, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump vite from 6.3.5 to 7.0.4
3 participants