Skip to content

front: modify navbar style #12612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

front: modify navbar style #12612

merged 1 commit into from
Jul 29, 2025

Conversation

Uriel-Sautron
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron commented Jul 24, 2025 •
edited
Loading

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner July 24, 2025 15:20
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jul 24, 2025
@SharglutDev
Copy link
Contributor

Can't find a mockup with the navbar and the scenario together. I guess it's suppose to go above the scenario header ?
If yes, we should also move back the "scenario impersonate" in it.

@Uriel-Sautron
Copy link
Contributor Author

Can't find a mockup with the navbar and the scenario together. I guess it's suppose to go above the scenario header ? If yes, we should also move back the "scenario impersonate" in it.

@SharglutDev
The navbar will not be associated with the scenario page.
You will find a discussion on this topic here

SharglutDev
SharglutDev reviewed Jul 25, 2025
View reviewed changes
@Uriel-Sautron Uriel-Sautron force-pushed the usn/fix-navbar branch 2 times, most recently from c940c94 to 3c393eb Compare July 28, 2025 13:02
SharglutDev
SharglutDev approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, you can close the last comment when fixed (seems the last push doesn't include the change)

@Uriel-Sautron
front: modify navbar style
3f23d6d 
Signed-off-by: Uriel-Sautron <[email protected]>
@Uriel-Sautron Uriel-Sautron enabled auto-merge July 29, 2025 09:03
@Uriel-Sautron Uriel-Sautron added this pull request to the merge queue Jul 29, 2025
Merged via the queue into dev with commit 71d6822 Jul 29, 2025
27 checks passed
@Uriel-Sautron Uriel-Sautron deleted the usn/fix-navbar branch July 29, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibautsailly thibautsailly thibautsailly left review comments

@SharglutDev SharglutDev SharglutDev approved these changes

@Yohh Yohh Awaiting requested review from Yohh

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: modify the navbar to match the mockup
3 participants
@Uriel-Sautron @SharglutDev @thibautsailly