-
Notifications
You must be signed in to change notification settings - Fork 54
Fix last stop for track projection #12590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2936df7
to
887c261
Compare
887c261
to
42126a7
Compare
e96ba22
to
8952c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for core with one small comment.
The formatting changes are unexpected, but whatever, it's one of the last few java files
core/src/main/java/fr/sncf/osrd/standalone_sim/EnvelopeStopWrapper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, well done!
bac13cb
to
6e9d63f
Compare
You need to run |
6e9d63f
to
8d3de35
Compare
Co-authored-by: Alwenn Charpentier <[email protected]> Signed-off-by: Florian Amsallem <[email protected]>
Signed-off-by: Florian Amsallem <[email protected]>
8d3de35
to
28f0379
Compare
Core: We did not manage the stops at the end of a simulation.
Editoast: The first and last points of a projected segment were randomly skipped. Adapt the simulation summary to return the arrival time of the train without its optional stop.
Before:

After:

Note
Check with @maelysLeratRosso what the expected behavior is.