Skip to content

Conversation

flomonster
Copy link
Member

@flomonster flomonster commented Jul 23, 2025

Core: We did not manage the stops at the end of a simulation.
Editoast: The first and last points of a projected segment were randomly skipped. Adapt the simulation summary to return the arrival time of the train without its optional stop.

Before:
image

After:
image

Note

Check with @maelysLeratRosso what the expected behavior is.

@flomonster flomonster requested a review from a team as a code owner July 23, 2025 13:17
@flomonster flomonster requested a review from Khoyo July 23, 2025 13:17
@github-actions github-actions bot added the area:core Work on Core Service label Jul 23, 2025
@Erashin Erashin force-pushed the fam/fix-last-stop-projection branch from 2936df7 to 887c261 Compare July 23, 2025 13:44
@flomonster flomonster force-pushed the fam/fix-last-stop-projection branch from 887c261 to 42126a7 Compare July 23, 2025 16:12
@flomonster flomonster requested a review from a team as a code owner July 23, 2025 16:12
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Jul 23, 2025
@flomonster flomonster marked this pull request as draft July 23, 2025 16:14
@flomonster flomonster requested a review from Erashin July 23, 2025 16:14
@flomonster flomonster changed the title Fix last stop projection Fix last stop for track projection Jul 23, 2025
@flomonster flomonster marked this pull request as ready for review July 23, 2025 16:20
@flomonster flomonster force-pushed the fam/fix-last-stop-projection branch 2 times, most recently from e96ba22 to 8952c41 Compare July 24, 2025 08:09
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for core with one small comment.

The formatting changes are unexpected, but whatever, it's one of the last few java files

Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, well done!

@flomonster flomonster force-pushed the fam/fix-last-stop-projection branch 2 times, most recently from bac13cb to 6e9d63f Compare July 24, 2025 14:35
@flomonster flomonster enabled auto-merge July 24, 2025 14:35
@Erashin
Copy link
Contributor

Erashin commented Jul 24, 2025

You need to run ./gradlew spotlessApply to solve format issues.

@flomonster flomonster force-pushed the fam/fix-last-stop-projection branch from 6e9d63f to 8d3de35 Compare July 25, 2025 08:04
flomonster and others added 2 commits July 25, 2025 14:45
Co-authored-by: Alwenn Charpentier <[email protected]>
Signed-off-by: Florian Amsallem <[email protected]>
@flomonster flomonster force-pushed the fam/fix-last-stop-projection branch from 8d3de35 to 28f0379 Compare July 25, 2025 12:45
@flomonster flomonster added this pull request to the merge queue Jul 25, 2025
Merged via the queue into dev with commit 32f6586 Jul 25, 2025
27 checks passed
@flomonster flomonster deleted the fam/fix-last-stop-projection branch July 25, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants