Skip to content

front: add new operational points for Miramas—Ventimiglia + Hourcade-St Jory LMR axis #12508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2025
Merged

front: add new operational points for Miramas—Ventimiglia + Hourcade-St Jory LMR axis #12508

merged 2 commits into from
Jul 30, 2025

Conversation

Tristramg
Copy link
Contributor

Marked as draft until we decide to open the axis

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jul 17, 2025
@Tristramg Tristramg moved this to Awaiting merge in Board PI 16 Jul 17, 2025
@Tristramg Tristramg self-assigned this Jul 17, 2025
@Tristramg Tristramg force-pushed the tmg/ventimiglia_axis branch from 2765f62 to 50a9498 Compare July 21, 2025 09:25
@Tristramg Tristramg moved this from Awaiting merge to Awaiting Validation in Board PI 16 Jul 21, 2025
@Tristramg Tristramg moved this from Awaiting Validation to Awaiting merge in Board PI 16 Jul 21, 2025
@woshilapin woshilapin changed the title front: add new operational points for Miramas—Ventimiglia LMR axis front: add new operational points for Miramas—Ventimiglia + Hourcade-St Jory LMR axis Jul 24, 2025
SharglutDev
SharglutDev approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested (didn't check there isn't any missing/extra OP from the new axes)

@alexandrergj
Copy link
Contributor

Checked every single one. All working perfect on local with a Smith LMR account.

@alexandrergj alexandrergj marked this pull request as ready for review July 30, 2025 15:24
@alexandrergj alexandrergj requested a review from a team as a code owner July 30, 2025 15:24
@alexandrergj alexandrergj force-pushed the tmg/ventimiglia_axis branch from 1acfc4e to a04e843 Compare July 30, 2025 15:37
@alexandrergj
Copy link
Contributor

alexandrergj commented Jul 30, 2025 •
edited
Loading

However the OPs for the Vintimiglia axis are missing... don't know why....

@alexandrergj
Copy link
Contributor

alexandrergj commented Jul 30, 2025 •
edited
Loading

Hourcade and Fos axis are in there, however the Vintimiglia axis OPs are not present

@alexandrergj
Copy link
Contributor

alexandrergj commented Jul 30, 2025 •
edited
Loading

Added missing OPs, now all OPs are set and work for: Fos, Hourcade, Vintimiglia areas (all tested, now none are missing from the CSV)

Enregistrement.2025-07-30.180750.mp4
Enregistrement.2025-07-30.180629.mp4

@alexandrergj alexandrergj enabled auto-merge July 30, 2025 16:17
@alexandrergj alexandrergj added this pull request to the merge queue Jul 30, 2025
Merged via the queue into dev with commit b7a3958 Jul 30, 2025
27 checks passed
@alexandrergj alexandrergj deleted the tmg/ventimiglia_axis branch July 30, 2025 16:40
@github-project-automation github-project-automation bot moved this from Awaiting merge to Done in Board PI 16 Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@alexandrergj alexandrergj alexandrergj approved these changes

Assignees

@Tristramg Tristramg

Labels
area:front Work on Standard OSRD Interface modules
Projects
Board PI 16
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tristramg @alexandrergj @SharglutDev