ui-charts: fix useManchetteWithSpaceTimeChart() errors with zero waypoints #11571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synar
reviewed
Apr 24, 2025
front/ui/ui-charts/src/manchette/hooks/useManchetteWithSpaceTimeChart.tsx
Outdated
Show resolved
Hide resolved
Synar
reviewed
Apr 24, 2025
|
Worth checking if it solves #10496 |
emersion
force-pushed
the
emr/use-manchette-with-space-time-chart-empty-waypoints
branch
from
8d86ec6 to
ec169a0
Compare
clarani
reviewed
Apr 28, 2025
front/ui/ui-charts/src/manchette/hooks/useManchetteWithSpaceTimeChart.tsx
Show resolved
Hide resolved
Synar
approved these changes
Apr 29, 2025
emersion
force-pushed
the
emr/use-manchette-with-space-time-chart-empty-waypoints
branch
from
ec169a0 to
d158316
Compare
…oints In multiple spots the hook assumed there is at least one waypoint in list. Add guards to avoid crashing with errors when that's the case. Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/use-manchette-with-space-time-chart-empty-waypoints
branch
from
d158316 to
0c6f0f8
Compare
emersion
deleted the
emr/use-manchette-with-space-time-chart-empty-waypoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multiple spots the hook assumed there is at least one waypoint in list. Add guards to avoid crashing with errors when that's the case.
Reported by @Castavo