feat: Add force_restart option to SkypilotBackend #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a `force_restart` parameter to the SkyPilotBackend class to force cancellation of existing art server tasks if needed. - Also added logic to sync local ART code to SkypilotBackend every time a new task is run, not just on cluster initialization. Does not fix the hanging training jobs, but might make it easier to debug them.
arcticfly
reviewed
May 21, 2025
| # If a local path was provided for art_version, ensure it is mounted so the latest | ||
| # code is synced to the remote cluster every time we (re)launch the art_server task. | ||
| if art_version is not None and os.path.exists(art_version): | ||
| art_server_task.set_file_mounts({"~/sky_workdir": art_version}) |
There was a problem hiding this comment.
Hmm, not sure we want to do this by default. It's conceivable that I might be editing code on the cluster itself, and I don't want that getting overwritten.
Maybe make this a parameter, and default to False?
There was a problem hiding this comment.
As discussed we'll experiment with keeping this on by default for now and can turn it off if it ends up being annoying for @arcticfly's workflow.
arcticfly
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
force_restartparameter to the SkyPilotBackend class to force cancellation of existing art server tasks if needed.Does not fix the hanging training jobs, but might make it easier to debug them.