Skip to content

Fix hanging #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 20, 2025
Merged

Fix hanging #126

merged 7 commits into from
May 20, 2025
+70 −9

Conversation

JonesAndrew
Copy link
Contributor

Make sure the training script shuts down cleanly. You either need to call .close or use the with syntax.

#112

@corbt corbt requested a review from bradhilton May 19, 2025 23:44
bradhilton
bradhilton requested changes May 20, 2025
View reviewed changes
@bradhilton bradhilton merged commit a8aa6ca into OpenPipe:main May 20, 2025
@bradhilton bradhilton mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradhilton bradhilton bradhilton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonesAndrew @bradhilton