Skip to content

Conversation

elsid
Copy link
Collaborator

@elsid elsid commented Apr 5, 2025

To set up generic Linux builds in CI. Use approach similar to windows.

@AnyOldName3
Copy link
Member

Quite a lot of this is very similar to the equivalent for Windows, so have you considered setting different operating systems up with matrix instead of just using it to pick between two different MSVC versions as we do now?

@elsid
Copy link
Collaborator Author

elsid commented Apr 6, 2025

Quite a lot of this is very similar to the equivalent for Windows, so have you considered setting different operating systems up with matrix instead of just using it to pick between two different MSVC versions as we do now?

This would require adding if to enable or disable certain steps. Also we will need to keep in mind the difference of the default shell (bash vs powershell). I don't think it worth it.

Comment on lines +217 to +228
sudo apt install -y
autoconf-archive
libegl1-mesa-dev
libgl-dev
libibus-1.0-dev
libltdl-dev
libwayland-dev
libx11-dev
libxext-dev
libxft-dev
libxkbcommon-dev
nasm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we installing these because they all have a distro-independent ABI and we expect the non-dev packages to be installed on all user machines? If so, we may want a comment saying so.

- name: Generate files containing a download url and hash for linux
run: |
mkdir -p openmw-deps/linux
src=vcpkg-x64-linux-${{ env.file }}.7z
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be sensible to include the compiler and version in the name like we do for Windows as it affects the ABI, just like it does on Windows. Thinking about it, it might have made some sense to put msvc2022 in the Windows filenames instead of just 2022, but it's not as big a deal as for Clang and GCC as 2022 won't get confused with 20 or 14, but it's not as obvious that 14 is a GCC version rather than a Clang one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants