feat(fs): full support webdav cross-driver copy and move #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
j2rong4cn
commented
Jul 24, 2025
j2rong4cn
commented
- close [BUG] WebDAV 跨驱动复制报错 500 #822
j2rong4cn
commented
Jul 24, 2025
j2rong4cn
changed the title
xrgzs
reviewed
Jul 25, 2025
server/webdav/file.go
Outdated
Comment on lines
67
to
73
| if err == nil { | ||
| srcName := path.Base(src) | ||
| dstName := path.Base(dst) | ||
| if srcName != dstName { | ||
| err = fs.Rename(ctx, path.Join(dstDir, srcName), dstName) | ||
| } | ||
| } |
There was a problem hiding this comment.
这样会不会有个问题，假如现在 dst 里面已经有了 a.zip，然后我给一个 src/a.zip 复制到 dst/b.zip，那是不是就会覆盖掉 dst/a.zip，再重命名呢🤔
There was a problem hiding this comment.
另外是不是所有的复制都存在这个问题，貌似是个设计上的缺陷
想明白了，有些网盘的复制应该就是这样的，不支持复制时改名
j2rong4cn
force-pushed
the
fix/webdav-transfer
branch
from
de1be5f to
61c5dfc
Compare
Suyunmeng
pushed a commit
that referenced
this pull request
Jul 30, 2025
* fix(fs): restore webdav cross-driver copy and move * fix bug * webdav支持复制、移动 文件夹 * 优化 * 。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.