fix(dropbox): incorrect path error during upload #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dezhishen
previously approved these changes
Aug 14, 2025
tuthanika
force-pushed
the
main
branch
3 times, most recently
from
c31648f to
40b91d2
Compare
xrgzs
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where Dropbox upload operations fail due to incorrect path handling when a root namespace ID is configured. The fix adds the missing Dropbox-API-Path-Root header to upload requests when a root namespace is specified.
- Add
Dropbox-API-Path-Rootheader to upload session methods whenRootNamespaceIdis set - Create a helper method to build the path root header JSON
- Add JSON tag to
RootNamespaceIdfield for proper serialization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| drivers/dropbox/util.go | Adds path root header logic to upload methods and implements helper function |
| drivers/dropbox/meta.go | Adds JSON tag to RootNamespaceId field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
xrgzs
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Fix the bug mentioned in this issue — caused by a missing header that prevents Dropbox from correctly identifying the path." Reference: #909