Skip to content

Enable Spring 4.0 WAR tests for Concurrency and MBean #32924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
+14 −2
Merged

Enable Spring 4.0 WAR tests for Concurrency and MBean #32924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dev/io.openliberty.springboot.fat40.concurrency.app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ apply from: '../wlp-gradle/subprojects/maven-central-mirror.gradle'

dependencies {
implementation('org.springframework.boot:spring-boot-starter-web')
providedRuntime('org.springframework.boot:spring-boot-starter-tomcat')
// Should use spring-boot-starter-tomcat as provideCompile, but gradle plugin
// is putting too much in lib-provided: see https://github.com/spring-gradle-plugins/dependency-management-plugin/issues/409
// providedCompile('org.springframework.boot:spring-boot-starter-tomcat')
providedRuntime('org.apache.tomcat.embed:tomcat-embed-core')
providedRuntime('org.apache.tomcat.embed:tomcat-embed-el')
providedRuntime('org.apache.tomcat.embed:tomcat-embed-websocket')
}

bootJar {
Expand Down
7 changes: 6 additions & 1 deletion dev/io.openliberty.springboot.fat40.mbean.app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ apply from: '../wlp-gradle/subprojects/maven-central-mirror.gradle'

dependencies {
implementation('org.springframework.boot:spring-boot-starter-web') // + ':' + sv['springBoot'])
providedRuntime('org.springframework.boot:spring-boot-starter-tomcat')
// Should use spring-boot-starter-tomcat as provideCompile, but gradle plugin
// is putting too much in lib-provided: see https://github.com/spring-gradle-plugins/dependency-management-plugin/issues/409
// providedCompile('org.springframework.boot:spring-boot-starter-tomcat')
providedRuntime('org.apache.tomcat.embed:tomcat-embed-core')
providedRuntime('org.apache.tomcat.embed:tomcat-embed-el')
providedRuntime('org.apache.tomcat.embed:tomcat-embed-websocket')
}

bootJar {
Expand Down
2 changes: 2 additions & 0 deletions ....openliberty.springboot.fat40_fat/fat/src/com/ibm/ws/springboot/support/fat/FATSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@
TemplateTests40.class,
ApplicationStartedEventTests40.class,
ConcurrencyAppTests40.class,
ConcurrencyAppTests40War.class,
MBeanAppTests40.class,
MBeanAppTests40War.class,
JmsSpringBootAppTests40.class,
JmsWebAppTests40.class

Expand Down