Report an error if ToolArg.name is not set #32827 #32850
Conversation
ttmunyunguma
changed the base branch from
integration
to
feature-mcp-server
ttmunyunguma
changed the title
ttmunyunguma
force-pushed
the
feature-mcp-server-32827
branch
from
34d4eae to
daf8d2a
Compare
ttmunyunguma
force-pushed
the
feature-mcp-server-32827
branch
from
d7a846d to
a398d16
Compare
- Main source needs to depend on the no parameters source set - No parameters source set needs to define its own dependencies, separately from BND, since the bnd build has to depend on it. - Since we need to depend on jakarta APIs, we need the jakarta project to export individual configurations for the dependencies we need so we can reference them from gradle.
…en-liberty into feature-mcp-server-32827
ttmunyunguma
force-pushed
the
feature-mcp-server-32827
branch
from
ebc19e8 to
f9f39d7
Compare
| @Tool(name = "illegalToolArgNameTool", title = "illegal ToolArgName Tool", description = "thows illegalArgumentExeption because of the ToolArgName") | ||
| public String illegalToolArgNameTool(@ToolArg(name = Tool.ELEMENT_NAME, description = "input to echo") String input) { |
There was a problem hiding this comment.
What we're testing here is a missing name rather than an "illegal" name.
We should define the argument like this:
@ToolArg(description = "input to echo") String inputWe should rename the test.
| String expectedErrorHeader = "Illegal arguments found in MCP Tool:"; | ||
| List<String> expectedErrorList = List.of("io.openliberty.mcp.internal.fat.noparamtool.NoParamTools.illegalToolArgNameTool"); | ||
| ExpectedAppFailureValidator.findAndAssertExpectedErrorsInLogs("Illegal Tool Arg: ", expectedErrorHeader, expectedErrorList, server); |
There was a problem hiding this comment.
This message isn't descriptive enough to tell the user what the problem is and what they need to do.
The problem is that a name was not provided for the parameter.
The solution is to either add a name to the @ToolArg annotation, or to add the -parameters compiler option to use the parameter name.
We don't have a name for the parameter, but we do know what position it's in so we can tell the user that.
There was a problem hiding this comment.
This is the message now
E CWWKZ0002E: An exception occurred while starting the application ExpectedNoParamNameFailureTest. The exception message was: com.ibm.ws.container.service.state.StateChangeException: org.jboss.weld.exceptions.DeploymentException: Missing arguments found in MCP Tool: Tool: class io.openliberty.mcp.internal.fat.noparamtool.NoParamTools.missingToolArgNameTool Tool argument name was not provided for the parameter. Either add a name to the @ToolArg annotation, or to add the -parameters compiler option to use the parameter name
|
Could you squash the commits before merging please? |
…y, review comments review comment to make names consistent Co-authored-by: Andrew Rouse <[email protected]>
ttmunyunguma
force-pushed
the
feature-mcp-server-32827
branch
from
44e490b to
7ad2d1e
Compare
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).Resolves Report an error if
ToolArg.nameis not set and the parameter name is not included in the class #32827