Fix mira probe timer not fired. #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is a mistake I have made, yes, this PR fix this. Thank you. |
fengjixuchui
added a commit
to fengjixuchui/itlwm
that referenced
this pull request
Dec 25, 2020
Fix mira probe timeout not fired. (OpenIntelWireless#465)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MiRA rate adaption algorithm rely on time-based trigger and event-based trigger to probe different transmission rates.
There is a bug in the code where time-based timers got deleted inside function
ieee80211_mira_cancel_timeouts. When future time-based event occurred, the timer won't be fired. This blocks probing better rates effectively. The original intention is to reset the timer only.The fix adds another function
ieee80211_mira_node_freeto release the timers when driver shutdown.