Skip to content

Bug fix: Assignment to constant variable #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morehawes merged 1 commit into from
Oct 19, 2022
Merged

Bug fix: Assignment to constant variable #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions assets/dist/waymark-js/js/waymark-js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7387,7 +7387,7 @@ function Waymark_Map() {
//Set by name?
if(typeof Waymark.config.map_init_basemap !== 'undefined') {
//Search
for(i in Waymark.config.tile_layers) {
for(var i in Waymark.config.tile_layers) {
var init_basemap_name = Waymark.config.map_init_basemap.toUpperCase();
var this_basemap_name = Waymark.config.tile_layers[i].layer_name.toUpperCase();

Expand All @@ -7400,7 +7400,7 @@ function Waymark_Map() {
}

//For each tile layer
for(i in Waymark.config.tile_layers) {
for(var i in Waymark.config.tile_layers) {
//Append URL?
if(typeof Waymark.config.tile_layers[i].append !== 'undefined') {
Waymark.config.tile_layers[i].layer_url += Waymark.config.tile_layers[i].append;
Expand Down Expand Up @@ -7435,7 +7435,7 @@ function Waymark_Map() {
var type = null;

//Iterate over all types
for(i in Waymark.config[layer_type + '_types']) {
for(var i in Waymark.config[layer_type + '_types']) {
//Use first as default
if(i == 0) {
type = Waymark.config[layer_type + '_types'][i];
Expand Down Expand Up @@ -7481,7 +7481,7 @@ function Waymark_Map() {
}
];

for(i in required) {
for(var i in required) {
//If undefined
if(typeof type[required[i]['key']] !== 'string') {
//Set default
Expand Down Expand Up @@ -7592,7 +7592,7 @@ function Waymark_Map() {
// case 'photos':
// waymark_data.type = 'photo';
//
// for(i in feature.properties[prop]) {
// for(var i in feature.properties[prop]) {
// //Set thumb
// if(typeof feature.properties[prop][i]['web_url'] !== 'undefined') {
// waymark_data.image_thumbnail_url = feature.properties[prop][i]['web_url'];
Expand Down Expand Up @@ -7885,7 +7885,7 @@ function Waymark_Map() {
var image_sizes = {};

//Grab these
for(i in Waymark.config.media_library_sizes) {
for(var i in Waymark.config.media_library_sizes) {
//Use fallback
image_sizes['image_' + Waymark.config.media_library_sizes[i] + '_url'] = fallback;

Expand Down Expand Up @@ -8126,7 +8126,7 @@ function Waymark_Map_Viewer() {
this.line_has_elevation_data = function(feature) {
if(feature.geometry.type == 'MultiLineString') {
//Each line
for(i in feature.geometry.coordinates) {
for(var i in feature.geometry.coordinates) {
//Each point
for(j in feature.geometry.coordinates[i]) {
//If has elevation data
Expand Down Expand Up @@ -8975,7 +8975,7 @@ function Waymark_Map_Editor() {
);

//Pre-defined types
for(i in types) {
for(var i in types) {
var type_key = Waymark.make_key(types[i][layer_type + '_title']);

ele.append(jQuery('<option />').val(type_key).text(types[i][layer_type + '_title']));
Expand Down Expand Up @@ -9325,7 +9325,7 @@ function Waymark_Map_Editor() {
//var keep_properties = ['title', 'name', 'description', 'photos'];
// var keep_properties = ['title', 'name', 'description'];
// //Each feature
// for(i in geo_json.features) {
// for(var i in geo_json.features) {
// //Each property
// for(key in geo_json.features[i].properties) {
// //We want this
Expand Down
4 changes: 2 additions & 2 deletions assets/dist/waymark-js/js/waymark-js.min.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ A big thank you to the following projects and their contributors. Without their

## Changelog ##

### 0.9.21 ###

* Bug fix. Uncaught TypeError: Assignment to constant variable.

### 0.9.20 ###

* Front-end <a href="https://www.waymark.dev/docs/submissions/">Submissions</a> can now be added to a <a href="https://www.waymark.dev/docs/collections/">Collection</a> by default. A collection for User and Guest submissions can be specified in Settings > Submissions > Default Collection.
Expand Down
4 changes: 4 additions & 0 deletions readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ A big thank you to the following projects and their contributors. Without their

== Changelog ==

= 0.9.21 =

* Bug fix. Uncaught TypeError: Assignment to constant variable.

= 0.9.20 =

* Front-end <a href="https://www.waymark.dev/docs/submissions/">Submissions</a> can now be added to a <a href="https://www.waymark.dev/docs/collections/">Collection</a> by default. A collection for User and Guest submissions can be specified in Settings > Submissions > Default Collection.
Expand Down
18 changes: 9 additions & 9 deletions waymark-js/dist/js/waymark-js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7387,7 +7387,7 @@ function Waymark_Map() {
//Set by name?
if(typeof Waymark.config.map_init_basemap !== 'undefined') {
//Search
for(i in Waymark.config.tile_layers) {
for(var i in Waymark.config.tile_layers) {
var init_basemap_name = Waymark.config.map_init_basemap.toUpperCase();
var this_basemap_name = Waymark.config.tile_layers[i].layer_name.toUpperCase();

Expand All @@ -7400,7 +7400,7 @@ function Waymark_Map() {
}

//For each tile layer
for(i in Waymark.config.tile_layers) {
for(var i in Waymark.config.tile_layers) {
//Append URL?
if(typeof Waymark.config.tile_layers[i].append !== 'undefined') {
Waymark.config.tile_layers[i].layer_url += Waymark.config.tile_layers[i].append;
Expand Down Expand Up @@ -7435,7 +7435,7 @@ function Waymark_Map() {
var type = null;

//Iterate over all types
for(i in Waymark.config[layer_type + '_types']) {
for(var i in Waymark.config[layer_type + '_types']) {
//Use first as default
if(i == 0) {
type = Waymark.config[layer_type + '_types'][i];
Expand Down Expand Up @@ -7481,7 +7481,7 @@ function Waymark_Map() {
}
];

for(i in required) {
for(var i in required) {
//If undefined
if(typeof type[required[i]['key']] !== 'string') {
//Set default
Expand Down Expand Up @@ -7592,7 +7592,7 @@ function Waymark_Map() {
// case 'photos':
// waymark_data.type = 'photo';
//
// for(i in feature.properties[prop]) {
// for(var i in feature.properties[prop]) {
// //Set thumb
// if(typeof feature.properties[prop][i]['web_url'] !== 'undefined') {
// waymark_data.image_thumbnail_url = feature.properties[prop][i]['web_url'];
Expand Down Expand Up @@ -7885,7 +7885,7 @@ function Waymark_Map() {
var image_sizes = {};

//Grab these
for(i in Waymark.config.media_library_sizes) {
for(var i in Waymark.config.media_library_sizes) {
//Use fallback
image_sizes['image_' + Waymark.config.media_library_sizes[i] + '_url'] = fallback;

Expand Down Expand Up @@ -8126,7 +8126,7 @@ function Waymark_Map_Viewer() {
this.line_has_elevation_data = function(feature) {
if(feature.geometry.type == 'MultiLineString') {
//Each line
for(i in feature.geometry.coordinates) {
for(var i in feature.geometry.coordinates) {
//Each point
for(j in feature.geometry.coordinates[i]) {
//If has elevation data
Expand Down Expand Up @@ -8975,7 +8975,7 @@ function Waymark_Map_Editor() {
);

//Pre-defined types
for(i in types) {
for(var i in types) {
var type_key = Waymark.make_key(types[i][layer_type + '_title']);

ele.append(jQuery('<option />').val(type_key).text(types[i][layer_type + '_title']));
Expand Down Expand Up @@ -9325,7 +9325,7 @@ function Waymark_Map_Editor() {
//var keep_properties = ['title', 'name', 'description', 'photos'];
// var keep_properties = ['title', 'name', 'description'];
// //Each feature
// for(i in geo_json.features) {
// for(var i in geo_json.features) {
// //Each property
// for(key in geo_json.features[i].properties) {
// //We want this
Expand Down
4 changes: 2 additions & 2 deletions waymark-js/dist/js/waymark-js.min.js
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions waymark-js/src/js/Waymark_Map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ function Waymark_Map() {
//Set by name?
if(typeof Waymark.config.map_init_basemap !== 'undefined') {
//Search
for(i in Waymark.config.tile_layers) {
for(var i in Waymark.config.tile_layers) {
var init_basemap_name = Waymark.config.map_init_basemap.toUpperCase();
var this_basemap_name = Waymark.config.tile_layers[i].layer_name.toUpperCase();

Expand All @@ -523,7 +523,7 @@ function Waymark_Map() {
}

//For each tile layer
for(i in Waymark.config.tile_layers) {
for(var i in Waymark.config.tile_layers) {
//Append URL?
if(typeof Waymark.config.tile_layers[i].append !== 'undefined') {
Waymark.config.tile_layers[i].layer_url += Waymark.config.tile_layers[i].append;
Expand Down Expand Up @@ -558,7 +558,7 @@ function Waymark_Map() {
var type = null;

//Iterate over all types
for(i in Waymark.config[layer_type + '_types']) {
for(var i in Waymark.config[layer_type + '_types']) {
//Use first as default
if(i == 0) {
type = Waymark.config[layer_type + '_types'][i];
Expand Down Expand Up @@ -604,7 +604,7 @@ function Waymark_Map() {
}
];

for(i in required) {
for(var i in required) {
//If undefined
if(typeof type[required[i]['key']] !== 'string') {
//Set default
Expand Down Expand Up @@ -715,7 +715,7 @@ function Waymark_Map() {
// case 'photos':
// waymark_data.type = 'photo';
//
// for(i in feature.properties[prop]) {
// for(var i in feature.properties[prop]) {
// //Set thumb
// if(typeof feature.properties[prop][i]['web_url'] !== 'undefined') {
// waymark_data.image_thumbnail_url = feature.properties[prop][i]['web_url'];
Expand Down Expand Up @@ -1008,7 +1008,7 @@ function Waymark_Map() {
var image_sizes = {};

//Grab these
for(i in Waymark.config.media_library_sizes) {
for(var i in Waymark.config.media_library_sizes) {
//Use fallback
image_sizes['image_' + Waymark.config.media_library_sizes[i] + '_url'] = fallback;

Expand Down
4 changes: 2 additions & 2 deletions waymark-js/src/js/Waymark_Map_Editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ function Waymark_Map_Editor() {
);

//Pre-defined types
for(i in types) {
for(var i in types) {
var type_key = Waymark.make_key(types[i][layer_type + '_title']);

ele.append(jQuery('<option />').val(type_key).text(types[i][layer_type + '_title']));
Expand Down Expand Up @@ -998,7 +998,7 @@ function Waymark_Map_Editor() {
//var keep_properties = ['title', 'name', 'description', 'photos'];
// var keep_properties = ['title', 'name', 'description'];
// //Each feature
// for(i in geo_json.features) {
// for(var i in geo_json.features) {
// //Each property
// for(key in geo_json.features[i].properties) {
// //We want this
Expand Down
2 changes: 1 addition & 1 deletion waymark-js/src/js/Waymark_Map_Viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ function Waymark_Map_Viewer() {
this.line_has_elevation_data = function(feature) {
if(feature.geometry.type == 'MultiLineString') {
//Each line
for(i in feature.geometry.coordinates) {
for(var i in feature.geometry.coordinates) {
//Each point
for(j in feature.geometry.coordinates[i]) {
//If has elevation data
Expand Down