Skip to content

Conversation

@dangoslen
Copy link
Contributor

@dangoslen dangoslen commented Aug 13, 2018

Addresses Issue #763

This PR adds the support for having multiple values in the @Produces and @Consumes annotations when using the JAXRSContract. Empty or null values are removed if present, and at least one non-empty or non-null value must be present.

To facilitate, I created a new method in Util that allows for removing values from an array that meet a Predicate criteria for removal.

@dangoslen dangoslen changed the title Addresses Issue #763 Adding Multiple Values for Consumes and Produces Aug 13, 2018
@velo velo added enhancement For recommending new capabilities waiting for votes Enhancements or changes proposed that need more support before consideration labels Aug 13, 2018
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I merge in 24 hours if nobody else asks for changes

@velo velo merged commit 6667b0f into OpenFeign:master Aug 14, 2018
velo pushed a commit that referenced this pull request Oct 7, 2024
* Adding multiple mediatype support for JaxRs contract

* Updating README for multiple values
velo pushed a commit that referenced this pull request Oct 8, 2024
* Adding multiple mediatype support for JaxRs contract

* Updating README for multiple values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement For recommending new capabilities waiting for votes Enhancements or changes proposed that need more support before consideration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants