Adds convenient overloaded constructor for Request.Options #2093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwek7
force-pushed
the
newOptionsConstructorMethod
branch
from
531385e to
0776122
Compare
|
build is fixed now |
velo
added a commit
that referenced
this pull request
Oct 7, 2024
Co-authored-by: miwanczuk <[email protected]> Co-authored-by: Marvin Froeder <[email protected]>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
Co-authored-by: miwanczuk <[email protected]> Co-authored-by: Marvin Froeder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes adding new convenient constructor for Request.Options that enables us to pass timeout as duration. In my apps timeout is very often passed around as duration, which is imo better than moving it around as magic number without explicit unit attached. This constructor overload simply feels like it should be there from user perspective.