Skip to content

Don't add slash to URI if it is a matrix parameter like (;matrixparam=value) #998

@ranjitc5

Description

@ranjitc5

After updating openfeign latest version I found that matrix parameters behaviour got changed. Seems its similar like #889

OpenFeign version : 10.1.0 or Latest

Please find below scenarios in which its creating a problem
When we have API end point with dynamic path and we try to get details using matrix params its creating a problem
For example:

Path ("{prefix}")
EmployeController {

  EmployeeList getEmployee(@PathParam("prefix") PathSegment pathSegment,
            @QueryParam("flag") String flag) throws Exception;
} 

Now when we try to call above mention api with latest version and after calling RequestTemplate -->> uri(matrix paramete details, true): its generate template uri like below

api/gituser/;includeDetails=false

Which was with earlier version like below

api/gituser;includeDetails=false

I have checked the same and I think we should add one more condition with semicolon in RequestTemplate --> url(string, boolean) method like
!uri.startsWith(";") for the matrix parameter.

I have few more scenarios which are creating same issue with latest version of open feign
Let me know if you need more details

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugUnexpected or incorrect behavior

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions