bugfix: SD maximum number of output channels was incorrectly set #2821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deslaughter
approved these changes
May 20, 2025
luwang00
approved these changes
May 20, 2025
A user had a case where they wanted to output ~8000 channels from _SD_. However, there was an inconsisntency in how the `MaxOutPts` was set. To fix this: - uncomment `MaxOutPts` to `SubDyn_Output_Param.f90` - remove `MaxOutPts` from `SubDyn_Output.f90` so it is in the autogenerated file instead - remove `MaxOutChs` from `SD_FEM.f90` and use `MaxOutPts` instead
andrew-platt
force-pushed
the
b/SD_MaxOutputs
branch
from
69fc32e to
bb2ab49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
A user had a case where they wanted to output ~8000 channels from SD. However, there was an inconsisntency in how the
MaxOutPtswas set. To fix this:MaxOutPtstoSubDyn_Output_Param.f90MaxOutPtsfromSubDyn_Output.f90so it is in the autogenerated file insteadMaxOutChsfromSD_FEM.f90and useMaxOutPtsinsteadRelated issue, if one exists
Fixes #2802
Impacted areas of the software
SubDyn outputs only.
Additional supporting information
Test results, if applicable
None affected