-
Notifications
You must be signed in to change notification settings - Fork 491
Merge of #163 (BeamDyn: Updated integration scheme for nodal load outputs) #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
output forces -- removed extra GlbRot transform on output QP forces / moments
New integration implemented by @andrew-platt.
…dev branch after merge from Envision
@andrew-platt Could you please look through these changes? A couple of tests failed. Is this an artifact of the modified computation of |
Hmm... these results don't look right. I'll try to take a look in more detail later in the week. UPDATE: I misread the plots. That is time, not distance along the x-axis. This does look correct! |
I further wanted to add the closeup - |
This looks correct to me. Do the Fy and My terms show similar trends as well? |
@andrew-platt I plotted the Fy and My and the My profile with the current approach shows load reversals near the blade tip (see close-up of red plot) which goes away with refinement in Entire blade - Zoomed in - |
After some discussion with @andrew-platt, since the load reversal vanishes with increasing the refinement, there is likely a slight under-sampling near the tip with where the trapezoidal quadrature points are defined. So it is suspected that this might be a small artifact of the spectral method resulting in a difference 4 orders of magnitude smaller than the largest load, and not an issue with the load integration scheme. |
Since this PR supercedes the PR #163, can we close that one? |
…load outputs) (OpenFAST#265) * Updated BD linearizaon perturbation precision * updated error handling in static solve * BD: fixed assumption about first-node relative rotation * BD bug fix: point load array size with multiple elements * BD bug fix: removed extra GlbRot transform on output QP loads output forces -- removed extra GlbRot transform on output QP forces / moments * BD bug fix: Updated integration of nodal output loads New integration implemented by @andrew-platt. * Fixes for multi-element load outputs at nodes * clean up a few comments and modify some code logic to align with the dev branch after merge from Envision * Merge conflict cleanup * Update the BeamDyn reg test baselines * Add more outputs in BeamDyn 5MW reg test case
…load outputs) (OpenFAST#265) * Updated BD linearizaon perturbation precision * updated error handling in static solve * BD: fixed assumption about first-node relative rotation * BD bug fix: point load array size with multiple elements * BD bug fix: removed extra GlbRot transform on output QP loads output forces -- removed extra GlbRot transform on output QP forces / moments * BD bug fix: Updated integration of nodal output loads New integration implemented by @andrew-platt. * Fixes for multi-element load outputs at nodes * clean up a few comments and modify some code logic to align with the dev branch after merge from Envision * Merge conflict cleanup * Update the BeamDyn reg test baselines * Add more outputs in BeamDyn 5MW reg test case
THIS PULL REQUEST IS READY TO MERGE
This pull request although ready to merge with current dev, requires further review of the failed tests and subsequent update of gold files
Feature or improvement description
This pull request merges #163 (authored by @bjonkman and @andrew-platt) into the current dev after review and code modifications to align with current dev.
Impacted areas of the software
Beamdyn
Additional supporting information
Automated test results
A couple of tests fail, but converge to the same result as the baseline solution
Twisted beam results -
Curved beam results -