Skip to content

Conversation

ashesh2512
Copy link
Contributor

@ashesh2512 ashesh2512 commented Mar 22, 2019

THIS PULL REQUEST IS READY TO MERGE

This pull request although ready to merge with current dev, requires further review of the failed tests and subsequent update of gold files

Feature or improvement description

This pull request merges #163 (authored by @bjonkman and @andrew-platt) into the current dev after review and code modifications to align with current dev.

Impacted areas of the software

Beamdyn

Additional supporting information

Automated test results

A couple of tests fail, but converge to the same result as the baseline solution

Twisted beam results -

Screen Shot 2019-03-22 at 3 12 35 PM

Curved beam results -

Screen Shot 2019-03-22 at 3 34 45 PM

@ashesh2512
Copy link
Contributor Author

ashesh2512 commented Mar 22, 2019

@andrew-platt Could you please look through these changes? A couple of tests failed. Is this an artifact of the modified computation of y%ReactionForce%Force and y%ReactionForce%Moment or do you suppose something else could have contributed to these changes?

@andrew-platt
Copy link
Collaborator

andrew-platt commented Mar 26, 2019

Hmm... these results don't look right. I'll try to take a look in more detail later in the week.

UPDATE: I misread the plots. That is time, not distance along the x-axis. This does look correct!
There are a lot of things that could contribute to the second timestep converging slightly differently. For static solves, we found things converged nicely after about 3 steps.

@ashesh2512
Copy link
Contributor Author

ashesh2512 commented Mar 26, 2019

I further wanted to add Fx and Mx plots along the beam axis for the standalone 5MW dynamics test case. The plots below show a clear improvement over the previously found oscillations in load profiles near the blade tip.
Blue - current approach
Red - approach modified via this pull request

Screen Shot 2019-03-26 at 9 01 39 PM

the closeup -

Screen Shot 2019-03-26 at 9 02 02 PM

@andrew-platt
Copy link
Collaborator

This looks correct to me. Do the Fy and My terms show similar trends as well?

@ashesh2512
Copy link
Contributor Author

ashesh2512 commented Mar 27, 2019

@andrew-platt I plotted the Fy and My and the My profile with the current approach shows load reversals near the blade tip (see close-up of red plot) which goes away with refinement in p. Furthermore I don’t see any such behavior in Fx. Also note, for the coarser p I do not see load reversal with the old approach.

Entire blade -

Screen Shot 2019-03-26 at 9 05 29 PM

Zoomed in -

Screen Shot 2019-03-26 at 9 05 54 PM

p-refinement
Screen Shot 2019-03-26 at 9 35 09 PM

p-refinement zoom in
Screen Shot 2019-03-26 at 9 36 14 PM

@ashesh2512
Copy link
Contributor Author

After some discussion with @andrew-platt, since the load reversal vanishes with increasing the refinement, there is likely a slight under-sampling near the tip with where the trapezoidal quadrature points are defined. So it is suspected that this might be a small artifact of the spectral method resulting in a difference 4 orders of magnitude smaller than the largest load, and not an issue with the load integration scheme.

@andrew-platt
Copy link
Collaborator

Since this PR supercedes the PR #163, can we close that one?

@ashesh2512 ashesh2512 merged commit cd8e4df into OpenFAST:dev Mar 27, 2019
rafmudaf pushed a commit to rafmudaf/openfast that referenced this pull request Apr 8, 2019
…load outputs) (OpenFAST#265)

* Updated BD linearizaon perturbation precision

* updated error handling in static solve

* BD: fixed assumption about first-node relative rotation

* BD bug fix: point load array size with multiple elements

* BD bug fix: removed extra GlbRot transform on output QP loads

output forces -- removed extra GlbRot transform on output QP forces / moments

* BD bug fix: Updated integration of nodal output loads

New integration implemented by @andrew-platt.

* Fixes for multi-element load outputs at nodes

* clean up a few comments and modify some code logic to align with the dev branch after merge from Envision

* Merge conflict cleanup

* Update the BeamDyn reg test baselines

* Add more outputs in BeamDyn 5MW reg test case
rafmudaf pushed a commit to rafmudaf/openfast that referenced this pull request Apr 9, 2019
…load outputs) (OpenFAST#265)

* Updated BD linearizaon perturbation precision

* updated error handling in static solve

* BD: fixed assumption about first-node relative rotation

* BD bug fix: point load array size with multiple elements

* BD bug fix: removed extra GlbRot transform on output QP loads

output forces -- removed extra GlbRot transform on output QP forces / moments

* BD bug fix: Updated integration of nodal output loads

New integration implemented by @andrew-platt.

* Fixes for multi-element load outputs at nodes

* clean up a few comments and modify some code logic to align with the dev branch after merge from Envision

* Merge conflict cleanup

* Update the BeamDyn reg test baselines

* Add more outputs in BeamDyn 5MW reg test case
@rafmudaf rafmudaf mentioned this pull request Nov 11, 2019
@ashesh2512 ashesh2512 deleted the beamdyn/loads branch March 17, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants