[Bug] Writing checkpoint files created empty fort.# files #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort.# files. Code was added to return early if the same file is closed multiple times. Also, the cleanup function was removed from FAST_CreateCheckpoint_T as it is not needed.
andrew-platt
approved these changes
May 6, 2024
…_Restart in serial, improve logic in CloseRegFile
andrew-platt
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
This PR fixes a bug in the
dev-unstable-pointersbranch where writing the checkpoint files would cause empty fort.# files to be generated in the same directory as the checkpoint files. This was caused by cleanup code being called on the registry file multiple times. Code was added to return early if the same file is closed multiple times. Also, the cleanup function was removed from FAST_CreateCheckpoint_T as it is no longer needed.Impacted areas of the software
ModReg.f90andFast_Subs.f90