hsapp: remove hsinput; use giu implementation of imput handler #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravestench
reviewed
Jul 4, 2021
gravestench
reviewed
Jul 4, 2021
gravestench
suggested changes
Jul 4, 2021
gravestench
approved these changes
Jul 26, 2021
gravestench
reviewed
Jul 26, 2021
Comment on lines
+33
to
41
| // RegisterKeyboardShortcuts registers a shortcuts for popup dialog | ||
| func (d *Dialog) RegisterKeyboardShortcuts(_ ...giu.WindowShortcut) { | ||
| // https://github.com/OpenDiablo2/HellSpawner/issues/327 | ||
| } | ||
|
|
||
| // KeyboardShortcuts returns a list of shortcuts | ||
| func (d *Dialog) KeyboardShortcuts() []giu.WindowShortcut { | ||
| return []giu.WindowShortcut{} | ||
| } |
There was a problem hiding this comment.
If we wanted the dialog modal to close when pressing escape, this is where we would define that, right?
There was a problem hiding this comment.
no, if we'd like to add shortcut to some specified dialog we need to handle it here. Closing dialogs by escape is currently done here:
Line 260 in 2a0e033
gravestench
reviewed
Jul 26, 2021
Comment on lines
-113
to
-119
| // RegisterKeyboardShortcuts adds a local shortcuts for this editor | ||
| func (e *DC6Editor) RegisterKeyboardShortcuts(inputManager *hsinput.InputManager) { | ||
| // Ctrl+Shift+S saves file | ||
| inputManager.RegisterShortcut(func() { | ||
| e.Save() | ||
| }, g.KeyS, g.ModShift+g.ModControl, false) | ||
| } |
There was a problem hiding this comment.
is this ctrl+shift+s hotkey being registered elsewhere, now?
There was a problem hiding this comment.
it isn't, however, I'm not really sure if this shortcut is necessary. saving editor data takes place on ctrl+s and this shortcut is registered in hsapp.
gravestench
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
handling input events deffinitely isn't a part of HellSpawner. since 1dfaa030a55f5ec37408bc26544e6666180fb9e0
giusupports that so we can usebuilt-ininput manager.