Expand allowed methods in disconnect mode #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 471 471
Lines 31074 31078 +4
Branches 877 877
=======================================
+ Hits 22452 22456 +4
Misses 8528 8528
Partials 94 94
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -260,7 +260,7 @@ | |||
| disconnect = kw_params.delete(:disconnect) | |||
| # The only commands allowed through in disconnect mode are read-only | |||
| # Thus we allow the get, list, tlm and limits_enabled and subscribe methods | |||
| if method_name =~ /get_\w*|list_\w*|^tlm|limits_enabled|subscribe/ | |||
| if method_name =~ /\w*_get$|^get_\w*|\w*_list$|^list_\w*|^tlm|^limits_enabled$|^subscribe$/ | |||
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
ryanmelt
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.