Skip to content

Display raw UINT/INT values as hex #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Display raw UINT/INT values as hex #821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79d86c1
Display raw UINT/INT values as hex
jmthomas Sep 12, 2023
85af3e4
Include both dec and hex
jmthomas Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion openc3-cosmos-init/plugins/packages/openc3-tool-common/src/components/DetailsDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,17 @@ export default {
}
}
}
this.rawValue = values[0][0]
if (
this.details.data_type.includes('INT') &&
!this.details.array_size
) {
// For INT and UINT display both dec and hex
this.rawValue = `${values[0][0]} (0x${values[0][0]
.toString(16)
.toUpperCase()})`
} else {
this.rawValue = values[0][0]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted hex to be in addition to the decimal display, not replace it.

Copy link
Member Author

@jmthomas jmthomas Sep 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like 0xA (10) or 10 (0xA)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That or a separate line. Either would be fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of those: 10 (0xA)

this.convertedValue = values[1][0]
this.formattedValue = values[2][0]
this.unitsValue = values[3][0]
Expand Down