Add Python streams and interfaces #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
==========================================
+ Coverage 72.68% 72.72% +0.03%
==========================================
Files 472 472
Lines 30776 30774 -2
Branches 878 878
==========================================
+ Hits 22370 22379 +9
+ Misses 8311 8301 -10
+ Partials 95 94 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ryanmelt
requested changes
Aug 29, 2023
| self.protocol_args = protocol_args | ||
| if self.protocol_type: | ||
| str(protocol_type).capitalize() + "Protocol" | ||
| # klass = OpenC3.require_class(class_name_to_filename(protocol_class_name)) |
There was a problem hiding this comment.
Need to actually do the dynamic import here.
| # self.add_protocol(klass, protocol_args, "PARAMS") | ||
|
|
||
| def connect(self): | ||
| super() |
…into python_interfaces
|
SonarCloud Quality Gate failed.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.