Force unique folder_name for tools #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthomas
approved these changes
Aug 24, 2023
| unless update | ||
| tools.each do |_tool_name, tool| | ||
| if tool['folder_name'] == @folder_name | ||
| raise "Tool with folder_name #{@folder_name} already exists at create" |
There was a problem hiding this comment.
Who catches this and how does it present itself to the user?
There was a problem hiding this comment.
Its caught like all other errors that happen during plugin install. Then presented to the user in installation status on the plugins tab.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
==========================================
- Coverage 72.66% 70.69% -1.98%
==========================================
Files 471 471
Lines 30651 30637 -14
Branches 877 877
==========================================
- Hits 22273 21658 -615
- Misses 8285 8886 +601
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.