Skip to content

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Aug 5, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (9709741) 72.79% compared to head (e4ad9f5) 72.82%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
+ Coverage   72.79%   72.82%   +0.03%     
==========================================
  Files         470      470              
  Lines       30576    30644      +68     
  Branches      867      875       +8     
==========================================
+ Hits        22258    22317      +59     
- Misses       8230     8236       +6     
- Partials       88       91       +3     
Flag Coverage Δ
ruby-api 50.61% <ø> (ø)
ruby-backend 80.65% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
openc3/lib/openc3/packets/structure_item.rb 92.94% <ø> (-0.05%) ⬇️
openc3/lib/openc3/packets/packet.rb 98.18% <100.00%> (-0.01%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas requested a review from ryanmelt August 11, 2023 22:55
@@ -126,6 +126,7 @@ def __init__(self, primary_key, **kw_args):
def create(self, update=False, force=False):
if not force:
existing = Store.hget(self.primary_key, self.name)
print(f"exist:{existing} update:{update}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover print.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 78 Code Smells

No Coverage information No Coverage information
3.5% 3.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jmthomas jmthomas merged commit c6a8565 into main Aug 15, 2023
@jmthomas jmthomas deleted the python_packets branch August 15, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants