Skip to content

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Jul 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 50.74% and project coverage change: -0.03 ⚠️

Comparison is base (0525c45) 72.98% compared to head (ef00c50) 72.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   72.98%   72.95%   -0.03%     
==========================================
  Files         470      470              
  Lines       30500    30516      +16     
  Branches      868      868              
==========================================
+ Hits        22261    22264       +3     
- Misses       8151     8164      +13     
  Partials       88       88              
Flag Coverage Δ
ruby-api 50.80% <16.66%> (-0.10%) ⬇️
ruby-backend 80.69% <69.76%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-cmd-tlm-api/app/controllers/trigger_controller.rb 12.79% <0.00%> (-0.79%) ⬇️
...ic/src/tools/Autonomic/Tabs/Reactions/Reaction.vue 93.85% <ø> (ø)
.../lib/openc3/microservices/reaction_microservice.rb 84.66% <23.52%> (-1.35%) ⬇️
...cmd-tlm-api/app/controllers/reaction_controller.rb 24.48% <40.00%> (+0.02%) ⬆️
...openc3/microservices/trigger_group_microservice.rb 95.64% <100.00%> (+0.07%) ⬆️
openc3/lib/openc3/models/reaction_model.rb 93.75% <100.00%> (+0.97%) ⬆️
openc3/lib/openc3/models/trigger_model.rb 97.26% <100.00%> (-1.39%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks clean

@jmthomas jmthomas merged commit 7ad48e4 into main Jul 7, 2023
@jmthomas jmthomas deleted the playwright branch July 7, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants