Skip to content

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Jun 2, 2023

closes #681

@jmthomas jmthomas requested a review from ryanmelt June 2, 2023 23:30
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (85df460) 70.83% compared to head (2e1d6d7) 70.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
- Coverage   70.83%   70.80%   -0.03%     
==========================================
  Files         471      471              
  Lines       30232    30246      +14     
  Branches      820      820              
==========================================
+ Hits        21414    21415       +1     
- Misses       8734     8746      +12     
- Partials       84       85       +1     
Flag Coverage Δ
frontend 58.45% <0.00%> (-0.13%) ⬇️
ruby-api 50.64% <ø> (ø)
ruby-backend 78.20% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cosmos-init/plugins/openc3-tool-base/src/router.js 33.33% <ø> (ø)
...ns/packages/openc3-cosmos-tool-admin/src/router.js 50.00% <0.00%> (-10.00%) ⬇️
...ackages/openc3-cosmos-tool-autonomic/src/router.js 50.00% <0.00%> (-16.67%) ⬇️
...es/openc3-cosmos-tool-bucketexplorer/src/router.js 100.00% <ø> (ø)
...packages/openc3-cosmos-tool-calendar/src/router.js 66.66% <0.00%> (-33.34%) ⬇️
...ackages/openc3-cosmos-tool-cmdsender/src/router.js 66.66% <0.00%> (-33.34%) ⬇️
...ages/openc3-cosmos-tool-cmdtlmserver/src/router.js 70.00% <0.00%> (-7.78%) ⬇️
...ges/openc3-cosmos-tool-dataextractor/src/router.js 66.66% <0.00%> (-33.34%) ⬇️
...ckages/openc3-cosmos-tool-dataviewer/src/router.js 66.66% <0.00%> (-33.34%) ⬇️
...ges/openc3-cosmos-tool-limitsmonitor/src/router.js 66.66% <0.00%> (-33.34%) ⬇️
... and 5 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit bd5e869 into main Jun 3, 2023
@jmthomas jmthomas deleted the not_found branch June 3, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotFoundComponent
2 participants