Skip to content

Conversation

jmthomas
Copy link
Member

closes #660

@jmthomas jmthomas requested a review from ryanmelt May 21, 2023 16:25
@jmthomas
Copy link
Member Author

Screenshot 2023-05-21 at 10 26 20 AM

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (3bf6d9c) 74.77% compared to head (3c31830) 74.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   74.77%   74.72%   -0.05%     
==========================================
  Files         454      455       +1     
  Lines       28412    28432      +20     
  Branches      545      545              
==========================================
+ Hits        21244    21247       +3     
- Misses       7084     7101      +17     
  Partials       84       84              
Flag Coverage Δ
frontend 77.42% <ø> (-0.20%) ⬇️
ruby-api 51.31% <ø> (-0.06%) ⬇️
ruby-backend 78.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/models/target_model.rb 73.42% <0.00%> (-0.29%) ⬇️
openc3/lib/openc3/utilities/process_manager.rb 27.84% <0.00%> (-0.73%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit 6b34a31 into main May 22, 2023
@jmthomas jmthomas deleted the screen_erb_error branch May 22, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen ERB error should be warning instead of crash
2 participants