Implement build_command #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 74.77% 71.06% -3.71%
==========================================
Files 454 470 +16
Lines 28412 30040 +1628
Branches 545 816 +271
==========================================
+ Hits 21244 21347 +103
- Misses 7084 8608 +1524
- Partials 84 85 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ryanmelt
requested changes
May 22, 2023
| @@ -75,5 +75,35 @@ def self.get_cmd_item(target_name, packet_name, param_name, type: :WITH_UNITS, s | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| def self.build_cmd(target_name, cmd_name, cmd_params, range_check, raw, scope:) | |||
There was a problem hiding this comment.
This doesn't make sense in this file. Maybe create a new DecomInterfaceTopic and move the other thing there too?
ryanmelt
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got pretty interesting so I'm open to any and all comments / suggestions. I didn't add any unit tests yet in case it needs a major refactor.
closes #663