Skip to content

Conversation

jmthomas
Copy link
Member

closes #662

@jmthomas jmthomas requested a review from ryanmelt May 18, 2023 23:04
Object.keys(source).forEach((key) => {
if (isObject(source[key])) {
if (!target[key] || !isObject(target[key])) {
target[key] = source[key]

Check warning

Code scanning / CodeQL

Prototype-polluting function

Properties are copied from [source](1) to [target](2) without guarding against prototype pollution.
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 3.46% and project coverage change: -3.70 ⚠️

Comparison is base (3bf6d9c) 74.77% compared to head (f0b6a48) 71.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   74.77%   71.07%   -3.70%     
==========================================
  Files         454      469      +15     
  Lines       28412    29985    +1573     
  Branches      545      816     +271     
==========================================
+ Hits        21244    21313      +69     
- Misses       7084     8589    +1505     
+ Partials       84       83       -1     
Flag Coverage Δ
frontend 58.64% <3.46%> (-18.98%) ⬇️
ruby-api 51.31% <ø> (-0.06%) ⬇️
ruby-backend 78.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/openc3-cosmos-ace-diff/src/dom/ensureElement.js 0.00% <0.00%> (ø)
...s/packages/openc3-cosmos-ace-diff/src/dom/query.js 0.00% <0.00%> (ø)
...ges/openc3-cosmos-ace-diff/src/helpers/debounce.js 0.00% <0.00%> (ø)
...ckages/openc3-cosmos-ace-diff/src/helpers/merge.js 0.00% <0.00%> (ø)
...c3-cosmos-ace-diff/src/helpers/normalizeContent.js 0.00% <0.00%> (ø)
...ges/openc3-cosmos-ace-diff/src/helpers/throttle.js 0.00% <0.00%> (ø)
.../openc3-cosmos-ace-diff/src/visuals/createArrow.js 0.00% <0.00%> (ø)
...ges/openc3-cosmos-ace-diff/src/visuals/getCurve.js 0.00% <0.00%> (ø)
...nc3-cosmos-ace-diff/src/visuals/getEditorHeight.js 0.00% <0.00%> (ø)
...ages/openc3-cosmos-ace-diff/src/visuals/getLine.js 0.00% <0.00%> (ø)
... and 4 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit b343211 into main May 22, 2023
@jmthomas jmthomas deleted the ace-diff branch May 22, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PLUGIN.txt diff tool during plugin upgrade does not insert final line correctly
2 participants