Skip to content

Conversation

ryanmelt
Copy link
Member

closes #667

@ryanmelt ryanmelt requested a review from jmthomas May 18, 2023 15:54
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (b343211) 71.08% compared to head (754694d) 71.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
- Coverage   71.08%   71.00%   -0.09%     
==========================================
  Files         469      468       -1     
  Lines       29982    29942      -40     
  Branches      816      816              
==========================================
- Hits        21313    21259      -54     
- Misses       8586     8598      +12     
- Partials       83       85       +2     
Flag Coverage Δ
frontend 58.41% <ø> (-0.24%) ⬇️
ruby-api 51.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...enc3/lib/openc3/logs/buffered_packet_log_writer.rb 95.23% <ø> (-1.32%) ⬇️
openc3/lib/openc3/logs/log_writer.rb 89.94% <ø> (-0.41%) ⬇️
openc3/lib/openc3/logs/packet_log_writer.rb 98.99% <ø> (-0.02%) ⬇️
...3/lib/openc3/microservices/reducer_microservice.rb 92.25% <ø> (-0.18%) ⬇️
openc3/lib/openc3/utilities/bucket_utilities.rb 91.95% <ø> (-0.19%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanmelt ryanmelt changed the title default to empty buffer on new file Update BufferedPacketLogWriter to empty buffer when closing file May 23, 2023
@ryanmelt ryanmelt merged commit 761b0b7 into main May 23, 2023
@ryanmelt ryanmelt deleted the empty_buffer branch May 23, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Data From 1 Target in a Particular Time Frame
2 participants