Skip to content

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Apr 27, 2023

DataViewer now supports custom user defined components (which are defined as Widgets). Each component can now take multiple packets rather than one. Thus I removed the ability to show more than 1 packet because as they are streamed in you don't really know which is which. History is still there and the search bar now works to filter the results.

I'm going to pull a lot of the DumpComponent into a base widget called HistoryComponent to make the default case of simply modifying the text output a lot easier. If you want to create a fully custom widget you can mixin Component and go to town.

I also still need to update all the playwright tests.

@jmthomas jmthomas requested a review from ryanmelt April 27, 2023 16:24
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Patch coverage: 85.38% and project coverage change: -0.07 ⚠️

Comparison is base (a999438) 74.48% compared to head (0724a5a) 74.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
- Coverage   74.48%   74.42%   -0.07%     
==========================================
  Files         462      464       +2     
  Lines       28670    28661       -9     
  Branches      588      582       -6     
==========================================
- Hits        21355    21331      -24     
- Misses       7221     7239      +18     
+ Partials       94       91       -3     
Flag Coverage Δ
ruby-api 51.47% <ø> (ø)
ruby-backend 78.55% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/models/widget_model.rb 39.39% <0.00%> (-0.61%) ⬇️
...es/openc3-cosmos-demo/src/DataviewertimeWidget.vue 40.00% <40.00%> (ø)
...viewer/src/tools/DataViewer/AddComponentDialog.vue 67.85% <75.00%> (-2.15%) ⬇️
...taviewer/src/tools/DataViewer/DynamicComponent.vue 88.88% <88.88%> (ø)
...nc3-cosmos-demo/src/DataviewerquaternionWidget.vue 90.00% <90.00%> (ø)
...ool-dataviewer/src/tools/DataViewer/DataViewer.vue 84.23% <95.74%> (+1.00%) ⬆️
...-dataviewer/src/tools/DataViewer/DumpComponent.vue 100.00% <100.00%> (+5.00%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost the number of packets to scroll. That needs to come back. Also should default to more than 1. (10 or 100?).

Probably also make height 100% to take up the whole pane.

@jmthomas
Copy link
Member Author

Lost the number of packets to scroll. That needs to come back. Also should default to more than 1. (10 or 100?).

Probably also make height 100% to take up the whole pane.

Number of packets doesn't work when you subscribe to more than one so I took it out. Could put back and just let it only work if they subscribe to one?

@ryanmelt
Copy link
Member

Its how many packets are rendered... I don't see why that matters with how many are subscribed.

@ryanmelt
Copy link
Member

ryanmelt commented May 5, 2023

This is great. The only thing I'm not sure about is the name "lastReceived". Got any better names for that?

@jmthomas jmthomas merged commit 6ffa413 into main May 6, 2023
@jmthomas jmthomas deleted the dataviewer_components branch May 6, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants