-
Notifications
You must be signed in to change notification settings - Fork 51
Dataviewer components #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
- Coverage 74.48% 74.42% -0.07%
==========================================
Files 462 464 +2
Lines 28670 28661 -9
Branches 588 582 -6
==========================================
- Hits 21355 21331 -24
- Misses 7221 7239 +18
+ Partials 94 91 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lost the number of packets to scroll. That needs to come back. Also should default to more than 1. (10 or 100?).
Probably also make height 100% to take up the whole pane.
Number of packets doesn't work when you subscribe to more than one so I took it out. Could put back and just let it only work if they subscribe to one? |
Its how many packets are rendered... I don't see why that matters with how many are subscribed. |
This is great. The only thing I'm not sure about is the name "lastReceived". Got any better names for that? |
DataViewer now supports custom user defined components (which are defined as Widgets). Each component can now take multiple packets rather than one. Thus I removed the ability to show more than 1 packet because as they are streamed in you don't really know which is which. History is still there and the search bar now works to filter the results.
I'm going to pull a lot of the DumpComponent into a base widget called HistoryComponent to make the default case of simply modifying the text output a lot easier. If you want to create a fully custom widget you can mixin Component and go to town.
I also still need to update all the playwright tests.