Table lookup matching definitions and then ask user #633
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
==========================================
+ Coverage 74.31% 74.52% +0.20%
==========================================
Files 460 462 +2
Lines 28545 28669 +124
Branches 588 588
==========================================
+ Hits 21214 21366 +152
+ Misses 7237 7211 -26
+ Partials 94 92 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jmthomas
changed the title
| else | ||
| head :not_found | ||
| end | ||
| rescue Exception => e |
There was a problem hiding this comment.
Do you not still want an overall Exception catch that can provide an error in json?
There was a problem hiding this comment.
The default Rails handler sends the exception. I'm not doing anything special and it's already 500. I'll verify but I think I tried that.
| @@ -189,7 +191,7 @@ def self.build_json(binary, definition_filename) | |||
| end | |||
| end | |||
| end | |||
| json.as_json(:allow_nan => true).to_json(:allow_nan => true) | |||
There was a problem hiding this comment.
You probably want at least the as_json call
There was a problem hiding this comment.
I moved both to the caller but I can leave that half as long as that's still returning a hash.
I have a playwright test for this. It pops up a green warning that says it can't be found along with the File Open dialog for you to select the config file. |
|
Default error handler: |
closes #581