Improve COSMOS 4 migration #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
=======================================
Coverage 74.31% 74.31%
=======================================
Files 460 460
Lines 28545 28545
Branches 588 588
=======================================
Hits 21214 21214
Misses 7237 7237
Partials 94 94
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ryanmelt
requested changes
Apr 23, 2023
| @@ -141,18 +141,21 @@ def migrate(args) | |||
|
|
|||
| # Overwrite plugin.txt with specified targets | |||
| plugin = File.open('plugin.txt', 'w') | |||
| plugin.puts "TARGET #{target_name}" | |||
|
|
|||
| FileUtils.mkdir 'targets' | |||
There was a problem hiding this comment.
This should probably have a force so that it doesn't fail if already there.
There was a problem hiding this comment.
It can't fail because we just generated a new plugin. This is only intended to be run once.
ryanmelt
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #364