Pause graph when clicking #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
==========================================
+ Coverage 74.31% 74.44% +0.12%
==========================================
Files 460 462 +2
Lines 28545 28652 +107
Branches 588 588
==========================================
+ Hits 21214 21330 +116
+ Misses 7237 7229 -8
+ Partials 94 93 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ryanmelt
requested changes
Apr 23, 2023
ryanmelt
requested changes
Apr 23, 2023
| setSelect: [ | ||
| (chart) => { | ||
| // Pause the graph while selecting a range to zoom | ||
| if (this.state == 'start' && chart.select.width > 0) { |
| @@ -819,6 +839,10 @@ export default { | |||
| setSelect: [ | |||
| (chart) => { | |||
| if (!this.zoomChart) { | |||
| // Pause the graph while selecting an overview range to zoom | |||
| if (this.state == 'start' && chart.select.width > 0) { | |||
ryanmelt
requested changes
Apr 23, 2023
| @@ -641,7 +641,7 @@ export default { | |||
| if (typeof rawValue === 'string' || isNaN(rawValue)) { | |||
| return 'NaN' | |||
| } else { | |||
| return rawValue == null ? '--' : rawValue.toFixed(2) | |||
There was a problem hiding this comment.
Comparing against null is the one place where you should use double equals. That will catch both null and undefined. Probably need to change those back.
ryanmelt
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #571