Skip to content

Do not disable command chooser when command name is null #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2025
Merged

Conversation

jmthomas
Copy link
Member

closes #2272

@ryanmelt Not sure why you changed this but if you have a target with no commands this effectively disables the command selection permanently.

@jmthomas jmthomas requested a review from ryanmelt August 10, 2025 23:53
Copy link

@ryanmelt
Copy link
Member

I meant to disable sending if there wasn't a command_name, not the entire chooser.
What happens if there is no command_name now? Is Send still enabled?

@jmthomas
Copy link
Member Author

I meant to disable sending if there wasn't a command_name, not the entire chooser. What happens if there is no command_name now? Is Send still enabled?

It works as expected. The chooser still disables the Send button when there are no commands.

Screenshot 2025-08-10 at 7 03 11 PM

@jmthomas jmthomas merged commit 7c7b522 into main Aug 17, 2025
21 of 22 checks passed
@jmthomas jmthomas deleted the cmd-select branch August 17, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command Sender target dropdown becomes disabled in 6.7.0 if no visible commands for target
3 participants