Fix traefik routing #2256
Merged
Fix traefik routing #2256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2256 +/- ##
==========================================
- Coverage 80.26% 80.26% -0.01%
==========================================
Files 638 638
Lines 47628 47587 -41
Branches 745 744 -1
==========================================
- Hits 38230 38196 -34
+ Misses 9315 9309 -6
+ Partials 83 82 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmthomas
commented
Aug 1, 2025
| TELEMETRY <%= target_name %> PARAMS BIG_ENDIAN "Params set by SETPARAMS command" | ||
| # NOTE: We don't really recommend using periods in packet names | ||
| # but we're doing it here to test the routing code | ||
| TELEMETRY <%= target_name %> PARAMS.PKT BIG_ENDIAN "Params set by SETPARAMS command" |
There was a problem hiding this comment.
I could be talked out of this but it does give us a chance to test it
jmthomas
commented
Aug 1, 2025
| tools-router: | ||
| rule: PathRegexp(`/tools/.*/.*[.](ttf|otf|woff|woff2|html|js|css|png|jpg|jpeg|gif|svg|ico|json|xml|txt|pdf|zip|tar|gz|tgz|csv|tsv|md|yaml|yml|bin|doc|docx|xls|xlsx|ppt|pptx|mp4|mp3|wav|avi|mov|flv|swf|apk|ipa|deb|rpm|exe|msi|dmg|pkg|sh|bat|cmd|ps1|py|pl|rb|php|java|class|jar|war|ear|so|dll|lib|a|o|obj|pdb|pdb|lib|dylib|framework)`) | ||
| rule: PathRegexp(`^/tools/.+/.+\.[a-zA-Z0-9]+$`) |
There was a problem hiding this comment.
Key was anchoring the Regexp with ^ and then just checking for any extension with \.[a-zA-Z0-9]+$
ryanmelt
requested changes
Aug 2, 2025
openc3-cosmos-init/plugins/packages/openc3-cosmos-tool-packetviewer/src/router.js
Show resolved
Hide resolved
ryanmelt
requested changes
Aug 4, 2025
|
ryanmelt
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2210