Dependencies #2248
Dependencies #2248
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2248 +/- ##
==========================================
+ Coverage 80.26% 80.28% +0.01%
==========================================
Files 638 638
Lines 47628 47585 -43
Branches 745 745
==========================================
- Hits 38230 38204 -26
+ Misses 9315 9298 -17
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -32,7 +32,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| ruby-version: ["3.2", "3.3"] | |||
| ruby-version: ["3.3", "3.4"] | |||
There was a problem hiding this comment.
Next major version of Alpine (3.22) is ruby 3.4 so I updated this to prepare
| "eslint-plugin-prettier": "5.5.3", | ||
| "eslint-plugin-vue": "10.3.0", | ||
| "prettier": "3.6.2", | ||
| "sass": "1.89.2", | ||
| "vite": "6.3.4", |
There was a problem hiding this comment.
Vite recently released 7.0.0 but we don't need to update yet
| # Pending merge of https://github.com/grpc/grpc/pull/39549 | ||
| # Should be fixed June 2025, look for grpc > 1.73.0 with a x86-linux-musl platform | ||
| && gem install grpc --platform ruby \ | ||
| && gem install grpc \ |
There was a problem hiding this comment.
Removed the --platform ruby since grpc is now up to date with musl
| @@ -1,7 +1,7 @@ | |||
| ARG OPENC3_DEPENDENCY_REGISTRY=docker.io | |||
| ARG TRAEFIK_CONFIG=traefik.yaml | |||
| # Consider updating openc3_build_ubi.sh when changing the release version | |||
| ARG OPENC3_TRAEFIK_RELEASE=v3.3.5 | |||
| ARG OPENC3_TRAEFIK_RELEASE=v3.4.4 | |||
There was a problem hiding this comment.
3.5.0 was release July 23 and looks like a straight forward upgrade for the next release
| @@ -1,7 +1,7 @@ | |||
| ARG OPENC3_DEPENDENCY_REGISTRY=docker.io | |||
| # Consider updating openc3_build_ubi.sh when changing the release version | |||
| # and build_multi_arch.sh | |||
| ARG OPENC3_MINIO_RELEASE=RELEASE.2025-06-13T11-33-47Z | |||
| ARG OPENC3_MINIO_RELEASE=RELEASE.2025-07-23T15-54-02Z | |||
There was a problem hiding this comment.
Hopefully this cleans up our Trivy scan
|
| @@ -16,6 +16,7 @@ on: | |||
| branches: [main] | |||
|
|
|||
| env: | |||
| RUBYOPT: --disable=frozen_string_literal | |||
There was a problem hiding this comment.
We run our specs with -f d --warnings which emits warnings. Ruby 3.4 now warns against modifying strings because apparently in Ruby 4 (next year?) they will enable frozen strings by default. So I explicitly turn off this warning because it completely overwhelms the logs.
| @@ -40,6 +40,6 @@ def is_mac? | |||
| # @param start [Integer] The number of stack entries to skip | |||
| # @return [Symbol] The name of the calling method | |||
| def calling_method(start = 1) | |||
| caller[start][/`([^']*)'/, 1].intern | |||
| caller[start][/[`']([^']*)'/, 1].intern | |||
There was a problem hiding this comment.
Ruby 3.4 finally changed the stack trace to eliminate that weird backtick
| @@ -79,6 +79,7 @@ spec = Gem::Specification.new do |s| | |||
| s.add_runtime_dependency 'bundler', '~> 2.3' | |||
| s.add_runtime_dependency 'csv', '~> 3.3' | |||
| s.add_runtime_dependency 'hiredis-client', '~> 0.22' | |||
| s.add_runtime_dependency 'fiddle', '~> 1.1' | |||
There was a problem hiding this comment.
This is used here only. Was that only working if you installed it manually?
There was a problem hiding this comment.
I didn't really check ... I just noticed that it no longer going to be a core gem in Ruby 3.4 so you have to explicitly include it. We still use the Win32 stuff in our serial driver.
No description provided.