Skip to content

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Jul 23, 2025

closes #28
closes #1179

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

❌ Patch coverage is 42.38411% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.04%. Comparing base (bad74c6) to head (b787d43).
⚠️ Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/models/cvt_model.rb 11.39% 70 Missing ⚠️
...smos-cmd-tlm-api/app/controllers/api_controller.rb 30.00% 7 Missing ⚠️
openc3/lib/openc3/models/target_model.rb 22.22% 7 Missing ⚠️
openc3/lib/openc3/api/tlm_api.rb 94.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2229      +/-   ##
==========================================
- Coverage   80.23%   80.04%   -0.19%     
==========================================
  Files         638      639       +1     
  Lines       47591    47891     +300     
  Branches      745      745              
==========================================
+ Hits        38186    38336     +150     
- Misses       9322     9472     +150     
  Partials       83       83              
Flag Coverage Δ
python 83.57% <ø> (-0.23%) ⬇️
ruby-api 84.69% <30.00%> (-0.16%) ⬇️
ruby-backend 82.72% <43.26%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmthomas jmthomas requested review from ryan-pratt, ryanmelt and clayandgen and removed request for ryan-pratt, ryanmelt and clayandgen July 23, 2025 13:53
Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great stuff! Need to fix ruff and spelling, and create a ticket to capture needed to move to a connection pool. Also need to address other comments or create tickets to capture.

case int():
if value > (2**63 - 1): # max int64 value
value = 2**63 - 1
elif value < -(2**63): # min int64 value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to adjust to handle sentinel value issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added issue #2258

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change the range here. It is a one line fix.

case int():
if value > (2**63 - 1): # max int64 value
value = 2**63 - 1
elif value < -(2**63): # min int64 value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change the range here. It is a one line fix.

Copy link

sonarqubecloud bot commented Aug 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@jmthomas jmthomas merged commit e76ed53 into main Aug 4, 2025
28 of 29 checks passed
@jmthomas jmthomas deleted the playback branch August 4, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TlmViewer handle bad value on screen Playback to Telemetry Screens
3 participants