-
Notifications
You must be signed in to change notification settings - Fork 51
TlmViewer Playback #2229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TlmViewer Playback #2229
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2229 +/- ##
==========================================
- Coverage 80.23% 80.04% -0.19%
==========================================
Files 638 639 +1
Lines 47591 47891 +300
Branches 745 745
==========================================
+ Hits 38186 38336 +150
- Misses 9322 9472 +150
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great stuff! Need to fix ruff and spelling, and create a ticket to capture needed to move to a connection pool. Also need to address other comments or create tickets to capture.
openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/Openc3Screen.vue
Show resolved
Hide resolved
case int(): | ||
if value > (2**63 - 1): # max int64 value | ||
value = 2**63 - 1 | ||
elif value < -(2**63): # min int64 value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to adjust to handle sentinel value issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added issue #2258
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just change the range here. It is a one line fix.
case int(): | ||
if value > (2**63 - 1): # max int64 value | ||
value = 2**63 - 1 | ||
elif value < -(2**63): # min int64 value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just change the range here. It is a one line fix.
|
closes #28
closes #1179