-
Notifications
You must be signed in to change notification settings - Fork 51
Document protocols with examples #2209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2209 +/- ##
==========================================
+ Coverage 80.23% 80.26% +0.02%
==========================================
Files 638 638
Lines 47616 47628 +12
Branches 745 745
==========================================
+ Hits 38207 38230 +23
+ Misses 9326 9315 -11
Partials 83 83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -45,7 +45,7 @@ Here is a snippet of code showing [PORT](../configuration/plugins#port-1) and [R | |||
```bash | |||
VARIABLE cfdp_microservice_name CFDP | |||
VARIABLE cfdp_route_prefix /cfdp | |||
VARIABLE cfdp_port 2905 | |||
VARIABLE cfdp_port 2906 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual CFDP port is 2906 so updating to match.
@@ -66,15 +66,15 @@ Here is an example using [PORT](../configuration/plugins#port) and [ROUTE_PREFIX | |||
```bash | |||
VARIABLE my_interface_name MY_INT | |||
VARIABLE my_route_prefix /myint | |||
VARIABLE my_port 2910 | |||
VARIABLE my_port 2888 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2910 is now taken by calendar-api so updating to differentiate
// Re-use the default mapping | ||
...MDXComponents, | ||
Tabs, | ||
TabItem, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This registers Tabs
and TabItem
so we can use them in our markdown
|
No description provided.