Skip to content

Add autocomplete to Tlm Viewer dropdowns #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

Conversation

clayandgen
Copy link
Contributor

Closes #2159
Screenshot 2025-07-01 at 1 51 53 PM
Adds autocomplete type-ahead (similar to command sender) to the dropdowns for Tlm Viewer

@clayandgen clayandgen requested review from jmthomas and ryan-pratt July 1, 2025 19:52
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.19%. Comparing base (3767c6d) to head (534fa27).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2181      +/-   ##
==========================================
+ Coverage   80.16%   80.19%   +0.02%     
==========================================
  Files         636      636              
  Lines       47555    47554       -1     
  Branches      745      745              
==========================================
+ Hits        38124    38135      +11     
+ Misses       9348     9336      -12     
  Partials       83       83              
Flag Coverage Δ
python 83.81% <ø> (+0.08%) ⬆️
ruby-api 84.70% <ø> (ø)
ruby-backend 82.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Jul 1, 2025

Copy link

sonarqubecloud bot commented Jul 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
76.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Jul 1, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the screenshot!

@clayandgen clayandgen merged commit c152b93 into main Jul 2, 2025
26 of 28 checks passed
@clayandgen clayandgen deleted the feature/screen-selector branch July 2, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make select screen drop down searchable in Telemetry Viewer
2 participants